ref(AccountSecurityEnroll): Re-order methods to make diffs readable #95405
+54
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95405 +/- ##
===========================================
+ Coverage 72.05% 87.80% +15.75%
===========================================
Files 10512 10495 -17
Lines 606370 605862 -508
Branches 23717 23683 -34
===========================================
+ Hits 436897 531996 +95099
+ Misses 167093 73508 -93585
+ Partials 2380 358 -2022 |
michellewzhang
approved these changes
Jul 14, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
…95405) Just moving two functions from lower in the file, up higher in the file. All the other callbacks depend on these two callbacks, so when we move to a functional component these will need to be defined at the top. Therefore, this PR will make the next set one slightly easier to read. Related to getsentry/frontend-tsc#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just moving two functions from lower in the file, up higher in the file.
All the other callbacks depend on these two callbacks, so when we move to a functional component these will need to be defined at the top. Therefore, this PR will make the next set one slightly easier to read.
Related to https://github.com/getsentry/frontend-tsc/issues/2